[AMD] perf-changelog: duplicate dsv4-fp4-mi355x-sglang TP4 fixed-seq-len entry#1795
[AMD] perf-changelog: duplicate dsv4-fp4-mi355x-sglang TP4 fixed-seq-len entry#1795Oseltamivir wants to merge 3 commits into
Conversation
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27589517861 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=27589525331 |
1 participant
Summary
Duplicates the
perf-changelog.yamlentry fordsv4-fp4-mi355x-sglangoriginally added in #1768. The duplicate entry is identical in content (config-keys, description, and pr-link).Test plan
Note
Low Risk
Changelog-only YAML append with no runtime or benchmark impact; the only downside is redundant history if consumers assume one entry per PR.
Overview
Appends a second
perf-changelog.yamlblock fordsv4-fp4-mi355x-sglangthat matches the entry already recorded for PR #1762 (TP4 fixed-seq-len search space and expanded 8k1k sweeps). No new config keys, descriptions, or benchmark behavior—only a duplicate changelog record at the end of the file.Reviewed by Cursor Bugbot for commit 5927254. Bugbot is set up for automated code reviews on this repo. Configure here.